Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Dropout modules/functions should take in generator= #25104

Open
ssnl opened this issue Aug 23, 2019 · 1 comment
Open

[FR] Dropout modules/functions should take in generator= #25104

ssnl opened this issue Aug 23, 2019 · 1 comment
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: nn Related to torch.nn module: random Related to random number generation in PyTorch (rng generator) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ssnl
Copy link
Collaborator

ssnl commented Aug 23, 2019 •
edited by pytorch-probot bot

To be consistent with all other random functions.

cc @ssnl
@ssnl ssnl added module: nn Related to torch.nn module: random Related to random number generation in PyTorch (rng generator) labels Aug 23, 2019
@izdeby izdeby added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 23, 2019
@samdow samdow mentioned this issue May 4, 2022
Open
@vadimkantorov
Copy link
Contributor

vadimkantorov commented Jul 17, 2023 •
edited

It's also important to ensure that Generator instances/their state can be "saved_for_backward". Then it can sometimes be used to avoid saving random tensors for backward and just reproducing them on the fly: e.g. as in #92927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: nn Related to torch.nn module: random Related to random number generation in PyTorch (rng generator) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vadimkantorov @ssnl @izdeby