Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user configure default timeouts on a per-RPC basis #29018

Closed
rohan-varma opened this issue Nov 1, 2019 · 1 comment
Closed

Let user configure default timeouts on a per-RPC basis #29018

rohan-varma opened this issue Nov 1, 2019 · 1 comment
Assignees
@rohan-varma
Labels
module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@rohan-varma
Copy link
Member

rohan-varma commented Nov 1, 2019 •
edited by pytorch-probot bot

馃殌 Feature

#28392 is adding timeouts per RPC, but it is currently a global timeout. Per @pritamdamania87's suggestion, we should:

1.Have a timeout parameter in RpcAgent.send().
2. For user RPCs, we always fill that in with the default rpc timeout.
3. For system RPCs, it'll default to 0 (which would be infinite) unless the system RPC sets it.
4. Later we can allow the user level RPC API to specify timeouts as well.## Motivation

cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528
@rohan-varma rohan-varma added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer labels Nov 1, 2019
@rohan-varma rohan-varma self-assigned this Nov 1, 2019
@rohan-varma rohan-varma mentioned this issue Nov 1, 2019
Closed
@xush6528 xush6528 mentioned this issue Nov 8, 2019
Open
@rohan-varma rohan-varma mentioned this issue Nov 28, 2019
Closed
@rohan-varma rohan-varma mentioned this issue Jan 28, 2020
Closed
@rohan-varma
Copy link
Member Author

Dup of #32686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohan-varma rohan-varma

Labels
module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohan-varma