Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] gcc 7.4 needs CMAKE_CXX_FLAGS="-std=gnu++11" #29739

Open
ssnl opened this issue Nov 13, 2019 · 1 comment
Open

[build] gcc 7.4 needs CMAKE_CXX_FLAGS="-std=gnu++11" #29739

ssnl opened this issue Nov 13, 2019 · 1 comment
Labels
module: build Build system issues module: dependency bug Problem is not caused by us, but caused by an upstream library we use triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ssnl
Copy link
Collaborator

ssnl commented Nov 13, 2019 •
edited

馃悰 Bug

Since I can't use conda gcc 7.3 (#29093), I tried to build master with system gcc 7.4 and met

CMake Error at third_party/fbgemm/third_party/asmjit/CMakeLists.txt:100 (target_compile_features):
  target_compile_features no known features for CXX compiler

  "GNU"

  version 7.4.0.
Call Stack (most recent call first):
  third_party/fbgemm/third_party/asmjit/CMakeLists.txt:332 (asmjit_add_target)

I was able to fix it by explicitly adding stdlib11, i.e., adding

CMAKE_CXX_FLAGS="-std=gnu++11",

to

pytorch/tools/setup_helpers/cmake.py

Line 289 in f0dd751

NUMPY_INCLUDE_DIR=NUMPY_INCLUDE_DIR,

Maybe I should submit this issue to asmjit repo?
@ssnl ssnl changed the title [build] gcc 7.4 needs CMAKE_CXX_STANDARD=14 [build] gcc 7.4 needs CMAKE_CXX_FLAGS="-std=gnu++11" Nov 13, 2019
@vincentqb vincentqb added module: build Build system issues module: dependency bug Problem is not caused by us, but caused by an upstream library we use labels Nov 14, 2019
@vincentqb
Copy link
Contributor

It would be a good idea to submit this upstream.

Have you tried adding the flags directly inline when building?

@vincentqb vincentqb added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: build Build system issues module: dependency bug Problem is not caused by us, but caused by an upstream library we use triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentqb @ssnl