Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] general nll_loss and cross_entropy along arbitrary dimension #29754

Open
ssnl opened this issue Nov 13, 2019 · 1 comment
Open

[FR] general nll_loss and cross_entropy along arbitrary dimension #29754

ssnl opened this issue Nov 13, 2019 · 1 comment
Labels
module: loss Problem is related to loss function triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ssnl
Copy link
Collaborator

ssnl commented Nov 13, 2019

Currently it is always taken along dim=1. Making the dim configurable should be really easy. I'd do it if this sounds reasonable.
@vincentqb vincentqb added module: loss Problem is related to loss function triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Nov 14, 2019
@vincentqb
Copy link
Contributor

Sounds like a good idea to me.

@fmassa -- is your thumbs up meaning the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: loss Problem is related to loss function triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentqb @ssnl