Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++ API] Support for CIFAR10 and CIFAR100 Datasets #34862

Closed
prabhuomkar opened this issue Mar 17, 2020 · 10 comments
Closed

[C++ API] Support for CIFAR10 and CIFAR100 Datasets #34862

prabhuomkar opened this issue Mar 17, 2020 · 10 comments
Labels
feature A request for a proper, new feature. module: cpp Related to C++ API module: vision triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@prabhuomkar
Copy link

prabhuomkar commented Mar 17, 2020

馃殌 Feature

C++ API should support Famous Open Datasets CIFAR10 and CIFAR100.
Dataset Reference: https://www.cs.toronto.edu/~kriz/cifar.html

Motivation

While creating PyTorch C++ tutorials https://github.com/prabhuomkar/pytorch-cpp, I came to know that PyTorch has support for these datasets via vision. As of now, C++ API for Datasets only has MNIST.
Support for standard datasets like CIFAR, COCO, ImageNet, etc out of the box will help developers play with C++ API easily.

Pitch

  • Add cifar.h header with TORCH_API CIFAR class.
  • Add cifar.cpp with both CIFAR10 and CIFAR100 support similar to vision for reading images, targets and getting train/test data.

Alternatives

N/A

Additional context

Reference C++ Implementation: cifar10.h and cifar10.cpp
Reference Python Implementation: cifar.py

cc @yf225 @fmassa

@prabhuomkar
Copy link
Author

prabhuomkar commented Mar 17, 2020

cc @yf225 @soumith @apaszke

I would like to contribute to this Issue.

@mrshenli mrshenli added feature A request for a proper, new feature. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: cpp Related to C++ API labels Mar 18, 2020
@yf225
Copy link
Contributor

yf225 commented Mar 20, 2020

@prabhuomkar Thanks a lot for the suggestions! My personal take is that we should put the C++ vision datasets in https://github.com/pytorch/vision, same as the Python ones. @fmassa Curious what are your thoughts on this?

@prabhuomkar
Copy link
Author

@fmassa would like to know your thoughts on this before closing this.

@soumyadipghosh
Copy link

@prabhuomkar Did you finally implement support for CIFAR-10/ImageNet in C++ in torchvision?

@soumyadipghosh
Copy link

@prabhuomkar Thats great! Are you aware of anything similar for ImageNet?

@prabhuomkar
Copy link
Author

Not yet, will try to add one by this weekend as an example

@soumyadipghosh
Copy link

That would be nice!

@prabhuomkar
Copy link
Author

@soumyadipghosh use this prabhuomkar/pytorch-cpp#73 to track?

@soumyadipghosh
Copy link

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a proper, new feature. module: cpp Related to C++ API module: vision triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

4 participants