Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c10 MetaprogrammingTest.FilterMap_onlyCopiesIfNecessary fails on Windows #35546

Closed
malfet opened this issue Mar 27, 2020 · 4 comments
Closed
Assignees
Labels
module: windows Windows support for PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@malfet
Copy link
Contributor

malfet commented Mar 27, 2020

Per pytorch_windows_vs2019_py36_cuda10.1_test2:

[ RUN      ] MetaprogrammingTest.FilterMap_onlyCopiesIfNecessary
..\c10\test\util\Metaprogramming_test.cpp(176): error: Expected equality of these values:
  2
  result[0].move_count
    Which is: 3
..\c10\test\util\Metaprogramming_test.cpp(178): error: Expected equality of these values:
  1
  result[1].move_count
    Which is: 2
..\c10\test\util\Metaprogramming_test.cpp(180): error: Expected equality of these values:
  2
  result[2].move_count
    Which is: 3
[  FAILED  ] MetaprogrammingTest.FilterMap_onlyCopiesIfNecessary (0 ms)
[ RUN      ] MetaprogrammingTest.FilterMap_onlyMovesIfNecessary_1
..\c10\test\util\Metaprogramming_test.cpp(194): error: Expected equality of these values:
  1
  result[0].move_count
    Which is: 2
..\c10\test\util\Metaprogramming_test.cpp(196): error: Expected equality of these values:
  1
  result[1].move_count
    Which is: 2
[  FAILED  ] MetaprogrammingTest.FilterMap_onlyMovesIfNecessary_1 (0 ms)

cc @peterjc123

@agolynski
Copy link
Contributor

just to make sure: for these issues you reported where tests fail on windows, the failures are limited to windows only?

@agolynski agolynski added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 27, 2020
@malfet
Copy link
Contributor Author

malfet commented Mar 27, 2020

@agolynski yes, same test is passing if I run it on Linux

@agolynski
Copy link
Contributor

Thanks, @malfet! I presume that is the case with other windows issues you've reported 3 days ago?

@mantaionut
Copy link
Collaborator

This is a duplicate of #25161 which is fixed with C++ 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: windows Windows support for PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: Done
Development

No branches or pull requests

3 participants