Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION] RPC server-side ThreadLocalState #38510

Open
mrshenli opened this issue May 14, 2020 · 0 comments
Open

[DISCUSSION] RPC server-side ThreadLocalState #38510

mrshenli opened this issue May 14, 2020 · 0 comments
Labels
module: multithreading Related to issues that occur when running on multiple CPU threads module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer oncall: jit Add this issue/PR to JIT oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mrshenli
Copy link
Contributor

mrshenli commented May 14, 2020

This is a followup discussion of #38439. We fix #38439 by restoring ThreadLocalState and distributed autograd context separately. Creating this issue to track discussion on whether distributed autograd context id belongs to ThreadLocalState.h or we should create RpcThreadLocalState.h or else. Below are some concerns and notes from an offline discussion with @xush6528 @ilia-cher and @pritamdamania87,

cc @suo @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar

@mrshenli mrshenli added oncall: jit Add this issue/PR to JIT oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: multithreading Related to issues that occur when running on multiple CPU threads module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer labels May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: multithreading Related to issues that occur when running on multiple CPU threads module: rpc Related to RPC, distributed autograd, RRef, and distributed optimizer oncall: jit Add this issue/PR to JIT oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

1 participant