Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some @slowtests are never run in CI #39061

Open
mruberry opened this issue May 27, 2020 · 2 comments
Open

Some @slowtests are never run in CI #39061

mruberry opened this issue May 27, 2020 · 2 comments
Labels
high priority module: tests Issues related to tests (not the torch.testing module) quansight-nack High-prio issues that have been reviewed by Quansight and are judged to be not actionable. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@mruberry
Copy link
Collaborator

mruberry commented May 27, 2020 •
edited by pytorch-probot bot

#39060, for example, which is broken.

See output of of our one slow test build (master only) here: https://circleci.com/api/v1.1/project/github/pytorch/pytorch/5584582/output/106/0?file=true&allocation-id=5ece29ff9a720f435538c71f-0-build%2F1426355C.

cc @ezyang @gchanan @zou3519 @bdhirsh @heitorschueroff @mruberry @VitalyFedyunin
@mruberry mruberry added high priority module: tests Issues related to tests (not the torch.testing module) labels May 27, 2020
@mruberry mruberry mentioned this issue May 27, 2020
Closed
@ngimel
Copy link
Collaborator

ngimel commented May 27, 2020

This test is nominally run, but since it requires more memory than our machines have, it is effectively skipped https://github.com/pytorch/pytorch/pull/33310/files.
This is a general problem, however, a handful of tests specifically added to test behavior of ops on large tensors legitimately require more than 6 GB memory that our test machines have.

@ezyang
Copy link
Contributor

ezyang commented May 27, 2020

See also #18856

@gchanan gchanan added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed triage review labels Jun 1, 2020
@mruberry mruberry added the quansight-nack High-prio issues that have been reviewed by Quansight and are judged to be not actionable. label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority module: tests Issues related to tests (not the torch.testing module) quansight-nack High-prio issues that have been reviewed by Quansight and are judged to be not actionable. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ezyang @gchanan @ngimel @mruberry