Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dtype arg support to torch.linalg.norm with ord='fro' and ord='nuc' #46255

Closed
kurtamohler opened this issue Oct 13, 2020 · 1 comment
Closed

Add dtype arg support to torch.linalg.norm with ord='fro' and ord='nuc' #46255

kurtamohler opened this issue Oct 13, 2020 · 1 comment
Assignees
@kurtamohler
Labels
function request A request for a new function or the addition of new arguments/modes to an existing function. module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: norms and normalization triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@kurtamohler
Copy link
Collaborator

kurtamohler commented Oct 13, 2020 •
edited by pytorch-probot bot

馃殌 Feature

torch.linalg.norm currently supports the dtype arg for all norm types except Frobenius and nuclear.

cc @ezyang @vincentqb @vishwakftw @jianyuh @nikitaved @pearu @mruberry @heitorschueroff
@kurtamohler kurtamohler self-assigned this Oct 13, 2020
@bdhirsh bdhirsh added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix module: custom-operators triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module shadow review Request the triage shadow to take a second look at your triage and see if they agree or not labels Oct 13, 2020
@ezyang ezyang added module: norms and normalization module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul and removed module: custom-operators shadow review Request the triage shadow to take a second look at your triage and see if they agree or not labels Oct 13, 2020
@mruberry mruberry added function request A request for a new function or the addition of new arguments/modes to an existing function. and removed enhancement Not as big of a feature, but technically not a bug. Should be easy to fix labels Oct 13, 2020
@mruberry
Copy link
Collaborator

We would accept a PR adding this behavior.

@kurtamohler kurtamohler mentioned this issue Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtamohler kurtamohler

Labels
function request A request for a new function or the addition of new arguments/modes to an existing function. module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul module: norms and normalization triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable dtype arg for torch.linalg.norm with order 'fro' and 'nuc' kurtamohler/pytorch
4 participants
@ezyang @kurtamohler @bdhirsh @mruberry