Fix passing of jit_opt_level #55897
Closed
Fix passing of jit_opt_level #55897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3a71e8b (more details on the Dr. CI page): Commit 3a71e8b was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
The jit_opt_level must be passed as void* directly not by reference. This avoids failures and miscompilations as the level will be kind of random instead of one of the valid values. Fixes pytorch#52147
mruberry
added
the
triaged
bertmaher
reviewed
Oct 14, 2021
| @@ -322,7 +322,7 @@ NvrtcFunction nvrtcCompile( | |||
| if (val <= 4 && val >= 0) { | |||
| jit_opt_level = static_cast<uint32_t>(val); | |||
| options.push_back(CU_JIT_OPTIMIZATION_LEVEL); | |||
| option_vals.emplace_back(&jit_opt_level); | |||
| option_vals.emplace_back((void*)jit_opt_level); | |||
There was a problem hiding this comment.
Probably a good idea to static_cast<uintptr_t>(val) up above to guarantee that this cast to void * is all good.
bertmaher
reviewed
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jit_opt_level must be passed as void* directly not by reference.
This avoids failures and miscompilations as the level will be kind of random instead of one of the valid values.
Fixes #52147
See the issue for more details