make ddp logging api to be private #57999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make ddp logging api to be private Differential Revision: [D28338485](https://our.internmc.facebook.com/intern/diff/D28338485/) [ghstack-poisoned]
zhaojuanmao
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
wayi1
as code owners
facebook-github-bot
added
the
oncall: distributed
💊 CI failures summary and remediationsAs of commit da28845 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
zhaojuanmao
added a commit
that referenced
this pull request
May 10, 2021
make ddp logging api to be private Differential Revision: [D28338485](https://our.internmc.facebook.com/intern/diff/D28338485/) ghstack-source-id: 128607185 Pull Request resolved: #57999
Codecov Report
@@ Coverage Diff @@
## gh/zhaojuanmao/75/base #57999 +/- ##
==========================================================
+ Coverage 76.83% 76.85% +0.01%
==========================================================
Files 1986 1986
Lines 197417 197417
==========================================================
+ Hits 151681 151716 +35
+ Misses 45736 45701 -35 |
|
This pull request has been merged in ac44569. |
|
This pull request has been reverted by ad4cd6e. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57999 make ddp logging api to be private ghstack-source-id: 128607185 Test Plan: unit test Reviewed By: rohan-varma Differential Revision: D28338485 fbshipit-source-id: bd2ae7c78904e93eed88be91876f5a832b5b7886
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
make ddp logging api to be private
Differential Revision: D28338485