You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes closer always evaluate to a tuple containing one item: either (True,) or (False,). Notice therefore that closer will always evaluate to truthy because a non-empty tuple is always truthy.
This is a problem because the following code will never be hit because closer is never falsey:
馃悰 Describe the bug
There is an unwanted comma on this line
pytorch/caffe2/contrib/gloo/gloo_test.py
Line 602 in 1b66915
This makes
closer
always evaluate to a tuple containing one item: either(True,)
or (False,)
. Notice therefore thatcloser
will always evaluate to truthy because a non-empty tuple is always truthy.This is a problem because the following code will never be hit because
closer
is never falsey:pytorch/caffe2/contrib/gloo/gloo_test.py
Lines 609 to 613 in 1b66915
so it looks like only closing path is covered in this test.
The solution is to remove the unwanted comma. I can make a PR for this?
Versions
NA
The text was updated successfully, but these errors were encountered: