Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing header file #83764

Open
wschin opened this issue Aug 19, 2022 · 4 comments
Open

Missing header file #83764

wschin opened this issue Aug 19, 2022 · 4 comments
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@wschin
Copy link
Collaborator

wschin commented Aug 19, 2022

馃殌 The feature, motivation and pitch

Hi, I always build PyTorch from source and link my library to it. Today, I tried link my library to PyTorch nightly package, the error message below came out.

Cannot open include file: 'torch/csrc/jit/passes/onnx/constant_map.h': No such file or directory

Could we add this header to the package? Or do you have specific policy regarding what should be included and what no? Thanks.

Alternatives

No response

Additional context

No response

@mikaylagawarecki
Copy link
Contributor

Hi! Could you please provide more information on which nightly you are using -- the collect_env.py script wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py should get information for you. Would retrying with a more recent nightly work?

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 19, 2022
@BowenBao
Copy link
Collaborator

@malfet Do you know what's the process if we want to add a few C++ api for exporter?

@malfet
Copy link
Contributor

malfet commented Aug 31, 2022

@malfet Do you know what's the process if we want to add a few C++ api for exporter?

One can just propose a PR that adds folder/header to

pytorch/setup.py

Lines 1065 to 1068 in 4b8ae04

'include/torch/csrc/jit/backends/*.h',
'include/torch/csrc/jit/generated/*.h',
'include/torch/csrc/jit/passes/*.h',
'include/torch/csrc/jit/passes/quantization/*.h',

But to be frank, I prefer this list to go shorter rather than longer. And say "Tensor.h" should not include more and more header than strictly speaking necessary.

@yan12125
Copy link

Cannot open include file: 'torch/csrc/jit/passes/onnx/constant_map.h': No such file or directory

I got the same error when trying to build upcoming onnxruntime 1.13, which includes torch/csrc/jit/passes/onnx/constant_map.h via torch/csrc/jit/passes/onnx.h. This specific issue can be resolved with #86852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

5 participants