Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorch_cpu.so is exposing some LLVM symbols #87642

Open
sanchitintel opened this issue Oct 24, 2022 · 0 comments
Open

libtorch_cpu.so is exposing some LLVM symbols #87642

sanchitintel opened this issue Oct 24, 2022 · 0 comments
Labels
module: build Build system issues module: cpp-extensions Related to torch.utils.cpp_extension triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@sanchitintel
Copy link
Collaborator

sanchitintel commented Oct 24, 2022

馃悰 Describe the bug

#63272 had hidden LLVM symbols by making LLVM a PRIVATE dependency of torch_cpu in caffe2/CMakeLists.txt, but libtorch_cpu.so is still exposing some LLVM symbols.

nm -D ./build/lib/libtorch_cpu.so | grep llvm
000000000ca82122 B FLAGS_torch_jit_llvm_use_fast_intrinsics
0000000009fe4650 T llvm_orc_deregisterEHFrameSectionWrapper
0000000009fe4720 T llvm_orc_registerEHFrameSectionWrapper
000000000a048800 T llvm_regcomp
000000000a049120 T llvm_regerror
000000000a04bba0 T llvm_regexec
000000000a04cfb0 T llvm_regfree
000000000a04d030 T llvm_strlcpy

This issue doesn't affect PyTorch directly but can affect a PyTorch C++ extension if it links to another library that also links to LLVM.
Even in that case, workarounds can be used, so it's probably not a high priority issue at this point. Thanks!

Versions

Master branch

cc @malfet @seemethere @zou3519 @ZhennanQin

@bdhirsh bdhirsh added module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: cpp-extensions Related to torch.utils.cpp_extension labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: build Build system issues module: cpp-extensions Related to torch.utils.cpp_extension triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

2 participants