Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note to torch.round docs to indicate that the return type of out is the same as input.dtype #89056

Closed
anjali411 opened this issue Nov 15, 2022 · 1 comment
Closed

Add a note to torch.round docs to indicate that the return type of out is the same as input.dtype #89056

anjali411 opened this issue Nov 15, 2022 · 1 comment
Labels
actionable module: docs Related to our documentation, both in docs/ and docblocks module: python frontend For issues relating to PyTorch's Python frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@anjali411
Copy link
Contributor

anjali411 commented Nov 15, 2022 •
edited

馃摎 The doc issue

One might expect that the output of torch.round will be an int tensor but that's not the case. Let's add a note to the doc to clarify that this is intended since it can be a little bit surprising for the user.

Suggest a potential alternative/fix

No response

cc @svekars @carljparker @albanD
@anjali411 anjali411 added module: docs Related to our documentation, both in docs/ and docblocks module: python frontend For issues relating to PyTorch's Python frontend labels Nov 15, 2022
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 15, 2022
@jennychristopher
Copy link
Contributor

I would like to tackle this as my first issue. Would you accept a PR ?

@jennychristopher jennychristopher mentioned this issue Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable module: docs Related to our documentation, both in docs/ and docblocks module: python frontend For issues relating to PyTorch's Python frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a note to torch.round doc to indicate the return type jennychristopher/pytorch
4 participants
@albanD @bdhirsh @anjali411 @jennychristopher