Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DescribeModel, worker is ready before model is loaded #1679

Closed
kevinyaoxm opened this issue Jun 10, 2022 · 0 comments
Closed

In DescribeModel, worker is ready before model is loaded #1679

kevinyaoxm opened this issue Jun 10, 2022 · 0 comments
Assignees
Labels
bug Something isn't working p0 high priority
Milestone

Comments

@kevinyaoxm
Copy link

馃悰 Describe the bug

worker.setStatus(isRunning ? "READY" : "UNLOADING");

resp.addWorker(workerId, startTime, isRunning, gpuId, memory, pid, gpuUsage);

we are using workerThread.isRunning as an indication of whether worker is ready. However workerThread is already running before model is loaded. Worker should not be ready until model is loaded.

Error logs

N/A

Installation instructions

N/A

Model Packaing

N/A

config.properties

No response

Versions

0.4.2

Repro instructions

n/a

Possible Solution

No response

@lxning lxning self-assigned this Jun 10, 2022
@lxning lxning added bug Something isn't working p0 high priority labels Jun 10, 2022
@lxning lxning added this to the v0.6.1 milestone Jun 10, 2022
@lxning lxning closed this as completed Jun 10, 2022
@msaroufim msaroufim added this to Done in v0.6.1 lifecycle Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 high priority
Projects
Development

No branches or pull requests

2 participants