Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement TorchServe metrics documentation #2495

Closed
lxning opened this issue Jul 24, 2023 · 0 comments 路 Fixed by #2560
Closed

Improvement TorchServe metrics documentation #2495

lxning opened this issue Jul 24, 2023 · 0 comments 路 Fixed by #2560
Assignees
@sekyondaMeta
Labels
internal Issues found internally triaged Issue has been reviewed and triaged

Comments

@lxning
Copy link
Collaborator

lxning commented Jul 24, 2023

馃摎 The doc issue

There are two metrics doc now.

They are not organized well to let user clearly know that TS supports two different metrics format.

  1. Prometheus realtime online
  2. Log format

Suggest a potential alternative/fix

We need combine the existing two metric doc together and clearly show user

  • how to config metrics format
  • how to config metrics
  • example

Also metrics doc is not reflected in https://pytorch.org/serve/
@agunapal agunapal added triaged Issue has been reviewed and triaged internal Issues found internally labels Jul 24, 2023
@sekyondaMeta sekyondaMeta self-assigned this Jul 24, 2023
@sekyondaMeta sekyondaMeta mentioned this issue Aug 31, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sekyondaMeta sekyondaMeta

Labels
internal Issues found internally triaged Issue has been reviewed and triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metrics Docs Updates sekyondaMeta/serve
3 participants
@agunapal @lxning @sekyondaMeta