TorchServe startup fails to honor valid combinations of config.properties and command line

[fbbradheintz]

I have models in my model_store folder, and the line model_store=model_store in my config.properties file.

The following two command lines work, with the first starting no endpoints and the second starting workers for the model:

torchserve --start --ts-config config_with_batch.properties
torchserve --start --ts-config config_with_batch.properties --models d161good=d161good.mar  --model-store model_store

In the first one, it takes the model store location from config; in the second, it ignores that in favor of the command line.

This command line fails (error message in the second line):

> torchserve --start --ts-config config_with_batch.properties --models d161good=d161good.mar
--model-store is required to load model locally.

Again the model store is specified, just not on the command line. TorchServe should check the config for missing parameters before rejecting a command line.

[mycpuorg]

Got it. Fallback to config properties when command line specifies incorrect properties.

IOW, this can be regarded as a "user override config failure". As in, user tried to override the config properties and passed incorrect configs. I'd argue that this is not a launch blocker, in fact, I would argue this is not a bug but requires a better error message.

[harshbafna]

#68 should fix this.

[fbbradheintz]

With the line model_store=model_store in the config file, and my model archive in the model_store folder, all of the following work:

torchserve --start --ts-config config.properties
torchserve --start --ts-config config.properties --model-store model_store
torchserve --start --ts-config config.properties --model-store model_store --models d161good=d161good.mar
torchserve --start --ts-config config.properties --models d161good=d161good.mar

With the same config and my model in the folder model_stash, the following work:

torchserve --start --ts-config config.properties
torchserve --start --ts-config config.properties --model-store model_stash
torchserve --start --ts-config config.properties --model-store model_stash --models d161good=d161good.mar

Under those conditions, the following starts the server but fails to start workers (which is expected, because it is looking in the wrong folder for the model):

torchserve --start --ts-config config.properties --models d161good=d161good.mar

This looks good - I'm merging. (I verified that the branch rebases onto master cleanly.)