Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MacOS 14 (Sonoma) runner, or XCode SDK 15? #4899

Closed
beveradb opened this issue Jan 20, 2024 · 1 comment
Closed

Add support for MacOS 14 (Sonoma) runner, or XCode SDK 15? #4899

beveradb opened this issue Jan 20, 2024 · 1 comment

Comments

@beveradb
Copy link

Hi folks,

Apologies if this is the wrong place to ask, but could we add a macOS 14 runner?

I'm trying to add support for FFT operations which were added to MPS in Sonoma:
pytorch/pytorch#116630

but the CI build fails as it's using the older XCode SDK MacOSX13.sdk which doesn't have the header:

/Users/ec2-user/runner/_work/pytorch/pytorch/aten/src/ATen/native/mps/MPSGraphSonomaOps.h:3:10: note: did not find header 'MPSGraphFourierTransformOps.h' in framework 'MetalPerformanceShadersGraph' (loaded from '/Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk/System/Library/Frameworks')

It seems like there will be a macOS 14 runner image available very soon:
actions/runner-images#9179

and folks in this thread seem to have worked around it by installing a newer XCode SDK on the macOS 13 runner:
actions/runner-images#7508 (comment)

I'd love to hear others' thoughts on how best to resolve this!

Thanks 🙇

@beveradb beveradb changed the title Add support for MacOS 14 (Sonoma) runners? Add support for MacOS 14 (Sonoma) runner, or XCode SDK 15? Jan 20, 2024
@malfet
Copy link
Contributor

malfet commented Jan 23, 2024

Installing new SDK is easy, but one should not build PyTorch only for MacOS, but rather build with older SDK, and embed necessary headers, see how it's done for say complex operations, so that one can run the same binary on MacOS 13 and MacOS 14 and use ops when available

@malfet malfet closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants