Create torchtnt.utils.lr_scheduler.TLRScheduler

[dmtrs]

Summary:

Introduce torchtnt.utils.lr_scheduler.TLRScheduler to manage compatibility of torch with expose of LRScheduler pytorch/pytorch#88503

It seems that issue persist still with 1.13.1 (see #285). Replace the get_version logic with try/except. _LRscheduler.

Fixes #285 https://github.com/pytorch/tnt/issues/285

[facebook-github-bot]

Hi @dmtrs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[ananthsub]

thanks for your contribution @dmtrs !

[codecov]

Codecov Report

Merging #286 (3796902) into master (98890cd) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   87.90%   87.89%   -0.01%     
==========================================
  Files          87       88       +1     
  Lines        5870     5874       +4     
==========================================
+ Hits         5160     5163       +3     
- Misses        710      711       +1     

Impacted Files	Coverage Δ
torchtnt/framework/auto_unit.py	80.79% <ø> (ø)
torchtnt/utils/lr_scheduler.py	66.66% <66.66%> (ø)
tests/framework/test_app_state_mixin.py	100.00% <100.00%> (ø)
torchtnt/framework/unit.py	86.99% <100.00%> (+0.37%)	⬆️
torchtnt/utils/__init__.py	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[facebook-github-bot]

@ananthsub has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@ananthsub has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[dmtrs]

@ananthsub Commit 0d1067e introduced linting error that is fixed with a separate commit. I am expecting ✅ CI pipeline.

Feel free to merge squash, if required to have clean history.

[facebook-github-bot]

@ananthsub has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ananthsub]

Thanks for your patience @dmtrs . This is now committed. We will aim to make a new pypi release soon containing this fix

[dmtrs]

Thanks so much for the support