You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given that our extensions are now completely independent from Python, we just need to know the location where they live and directly call into torch.ops.load_library.
Note that we will also need to make the solution compatible with fbcode
The text was updated successfully, but these errors were encountered:
@prabhat00155 this might be related to the task I've assigned you. At least the part of the extension loading (hopefully we will not need to change the build, but it's not 100% sure)
馃殌 Feature
Related to #2349
We currently need to
#include <Python.h>
invision/torchvision/csrc/vision.cpp
Line 4 in 96ad7f0
as well as we need to define
PyInit__C
for Windowsvision/torchvision/csrc/vision.cpp
Lines 15 to 22 in 96ad7f0
This is ideally not needed. Windows builds currently require it due to an artifact on how we build our C++ extensions I believe (with setuptools).
We should try to remove this. This might involve using CMake to compiling the extensions (instead of setuptools), so might involve significant rework.
Further discussion can be found in #3087 (comment)
For reference, this is how TF extensions does it for loading extensions, vs our custom code in
vision/torchvision/extension.py
Lines 8 to 47 in 96ad7f0
Given that our extensions are now completely independent from Python, we just need to know the location where they live and directly call into
torch.ops.load_library
.Note that we will also need to make the solution compatible with fbcode
The text was updated successfully, but these errors were encountered: