Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONNX tests fail due to upstream bug #7980

Closed
pmeier opened this issue Sep 21, 2023 · 2 comments · Fixed by #7982
Closed

ONNX tests fail due to upstream bug #7980

pmeier opened this issue Sep 21, 2023 · 2 comments · Fixed by #7982
Labels
dependency issue module: ci module: onnx

Comments

@pmeier
Copy link
Collaborator

pmeier commented Sep 21, 2023 •
edited
Loading

For example https://github.com/pytorch/vision/actions/runs/6259955045?pr=7979#summary-16997013188

This was introduced in the 1.16.0 release that was published yesterday. See microsoft/onnxruntime#17631

cc @neginraoof @justinchuby @seemethere
@pmeier
Copy link
Collaborator Author

pmeier commented Sep 21, 2023

From the linked thread it seems that we just need to exclude 1.16.0 from the installed versions.

@pmeier pmeier mentioned this issue Sep 21, 2023
Merged
@thiagocrepaldi thiagocrepaldi mentioned this issue Sep 21, 2023
Merged
@thiagocrepaldi
Copy link
Contributor

thiagocrepaldi commented Sep 21, 2023 •
edited
Loading

Let's fix vision to use the correct format with #7982 and keep ort 1.16.0

The latest ort has a bunch of important performance and bug fixes that we are better off leveraging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependency issue module: ci module: onnx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update InferenceSession call to latest format thiagocrepaldi/vision
2 participants
@thiagocrepaldi @pmeier