Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add torch.compile support for all ops #8055

Closed
6 tasks done
NicolasHug opened this issue Oct 20, 2023 · 1 comment · Fixed by #8144
Closed
6 tasks done

Add torch.compile support for all ops #8055

NicolasHug opened this issue Oct 20, 2023 · 1 comment · Fixed by #8144

Comments

@NicolasHug
Copy link
Member

NicolasHug commented Oct 20, 2023

We should add support for torch.compile in all of our ops (meta implem, symint support, etc.) and use the opcheck test suite. See https://docs.google.com/document/d/1W--T6wz8IY8fOI0Vm8BF44PdBgs283QvpelJZWieQWQ/edit#heading=h.pnrqcv6bkfn3 for more details.

cc @pmeier

@NicolasHug
Copy link
Member Author

NicolasHug commented Oct 31, 2023

Current status: all the ops above now have proper support for torch.compile except for some MPS-related issues, which we can leave out for now. I had to remove opcheck testing for the ops below because the opcheck suite isn't really compatible with pytest parametrized tests ATM. We should still add manual tests for them though:

  • PSRoiAlign
  • RoiPool
  • PSRoiPool

EDIT: all done in #8144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant