Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Convert Error in the Doc. #177

Closed
mqzhang1999 opened this issue Dec 17, 2022 · 2 comments · Fixed by #180
Closed

Unit Convert Error in the Doc. #177

mqzhang1999 opened this issue Dec 17, 2022 · 2 comments · Fixed by #180
Assignees

Comments

@mqzhang1999
Copy link

Code Sample, a minimal, complete, and verifiable piece of code

# Your code here

Problem description

On https://pyspectral.readthedocs.io/en/latest/api.html, the comment of the function pyspectral.blackbody.blackbody_wn, the unit convert "Converting from SI units to mW/m^2 sr^-1 (cm^-1)^-1: 1.0 W/m^2 sr^-1 (m^-1)^-1 = 0.1 mW/m^2 sr^-1 (cm^-1)^-1" is error . It should be 1E5, not 0.1.

Expected Output

Actual Result, Traceback if applicable

Versions of Python, package at hand and relevant dependencies

Thank you for reporting an issue !

@adybbroe
Copy link
Collaborator

Thanks, you are absolutely right! Strange, since I thought we fixed this long time ago, it is correct a bit further up in the planck function so apparently we forgot to also update this. Thanks anyway.

@adybbroe
Copy link
Collaborator

Ah, now I see this should have been fixed in #117 but it wasn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants