Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C extension does not compile on py3.9 without re-cythonizing #29

Closed
danieldjewell opened this issue Jan 30, 2021 · 1 comment · Fixed by #30
Closed

C extension does not compile on py3.9 without re-cythonizing #29

danieldjewell opened this issue Jan 30, 2021 · 1 comment · Fixed by #30

Comments

@danieldjewell
Copy link

Building master fails on cpython 3.9.1:

geotiepoints/multilinear_cython.c:24742:26: error: no member named 'tp_print' in
'struct _typeobject'
__pyx_type___pyx_array.tp_print = 0;
~~~~~~~~~~~~~~~~~~~~~~ ^
geotiepoints/multilinear_cython.c:24747:32: error: no member named 'tp_print' in
'struct _typeobject'
__pyx_type___pyx_MemviewEnum.tp_print = 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
geotiepoints/multilinear_cython.c:24762:31: error: no member named 'tp_print' in
'struct _typeobject'
__pyx_type___pyx_memoryview.tp_print = 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
geotiepoints/multilinear_cython.c:24775:36: error: no member named 'tp_print' in
'struct _typeobject'
__pyx_type___pyx_memoryviewslice.tp_print = 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

Removing geotiepoints/multilinear_cython.c and running cythonize -3 multilinear_cython.pyx appears to fix the issue .... (Cython 0.29.21)

I saw #4 and while on one hand pre-generating the C source does make it possible to install w/o Cython, I'm not sure that Cython was designed around that idea?

@djhoese
Copy link
Member

djhoese commented Jan 30, 2021

Thanks for pointing this out. While I have always liked the idea of bundling the rendered C/C++ it has definitely caused more problems in the last couple years for the few packages pytroll uses cython in. I'd be OK with always re-rendering and including cython as a build requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants