Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying commits on the pyup-initial-update branch caused individual PRs to open #211

Closed
edmorley opened this issue Apr 18, 2017 · 4 comments

Comments

@edmorley
Copy link

edmorley commented Apr 18, 2017

STR:

  1. Add https://github.com/mozilla/treeherder to pyup.io
  2. Wait for the initial PR test to complete
  3. Notice that one of the updates causes a test failure (in this case, isort was updated meaning it now catches a lint case it missed before)
  4. Add a commit to the pyup-initial-update branch locally to fix the issue
  5. Use interactive rebase to (a) move the test-fixup commit to before the others (since that way if bisected, the repository always passes tests at any revision), (b) tweak the commit message for the pyup-bot commits
  6. Force push to the branch to update the PR

Expected:
pyup.io bot does nothing until the PR is merged/closed.

Actual:
pyup.io bot opens 18 PRs (one for each of the dependencies in the initial PR), which is pretty spammy.

@jayfk
Copy link
Contributor

jayfk commented Apr 18, 2017

This should be a supported workflow, I agree.

The problem here is that the bot is building up state by checking for open/closed PRs. I believe you've renamed the initial update, which caused the bot to switch to the "one PR for every update" mode.

This needs to be documented! Sorry for the spam.

@edmorley
Copy link
Author

Ah it was the PR title change not the rebase?

I was presuming it would have used the pull request number rather than the title, or given the message "Close this pull request and delete the branch", perhaps the presence of the branch itself (ie renaming the branch would have caused issues).

@jayfk
Copy link
Contributor

jayfk commented Apr 18, 2017

Yeah, it's the title.

Using the pull request number is state on its own that needs to be saved somewhere. The bot is designed in a way that you can run it on its own using just the command line interface, a GitHub oAuth token and the repo name.

This way you are independent from the service running on pyup.io.

@chris48s
Copy link

chris48s commented Jan 2, 2018

Apologies for hijacking this issue slightly, but you mention

"one PR for every update" mode

Is it possible to configure this manually as a workaround for #264 ? I can't seem to be a setting for it in the docs.

@edmorley edmorley closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants