Fix mimetype confusion during tests #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like it's easy for python to get confused when you name a file the same as a dependent module. This happened for mimetypes, and seems to call the wrong mimetypes when trying to call add_type.
|
I think if you also take PR #112 we can get back to passing? The one test that fails (and isn't style related, that is fixed by the other PR), passes on this branch with this fix. |
|
Merged this and the referenced one. Lets see if this unbreaks the tests. Thank you! |
|
Well looks like we're closer to unbreaking the tests. The other PR will get the style ones. I'm still vexed as to why this didn't fix that last failing test. It didn't fail in PR #112 's travis branch run! |
|
I think it is related to https://github.com/astropy/ccdproc/pull/650/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like it's easy for python to get confused when you name
a file the same as a dependent module. This happened for mimetypes,
and seems to call the wrong mimetypes when trying to add_type the
second time.