Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity corrections #2876

Merged
merged 2 commits into from Apr 15, 2024
Merged

Coverity corrections #2876

merged 2 commits into from Apr 15, 2024

Conversation

tasleson
Copy link
Contributor

Running coverity on version 0.15.0 which is the latest packaged version for fedora is reporting some errors. I believe this PR addresses some potential issues that should be considered for inclusion.

@tasleson tasleson mentioned this pull request Mar 28, 2022
Closed
@coveralls
Copy link

coveralls commented Mar 28, 2022 •
edited

Coverage Status

Coverage increased (+0.0006%) to 92.398% when pulling fad64d3 on tasleson:coverity_fixes into 6e2b852 on pywbem:master.

@andy-maier
Copy link
Contributor

@tasleson Thanks for this. We'll gladly merge that to the master branch.

PS: The nocaselist/nocasedict packages were introduced in pywbem 1.0.0, and the latest 0.x version is 0.17.6. So in theory you should be able to upgrade pywbem in fedora to 0.17.6. Do you know of anything that would prevent that (other than work)?

@tasleson
Copy link
Contributor Author

PS: The nocaselist/nocasedict packages were introduced in pywbem 1.0.0, and the latest 0.x version is 0.17.6. So in theory you should be able to upgrade pywbem in fedora to 0.17.6. Do you know of anything that would prevent that (other than work)?

I'm not sure, I'll take a look and see if we can move up to 0.17.6, thanks.

andy-maier
andy-maier reviewed Mar 30, 2022
View reviewed changes
pywbem/_recorder.py Outdated Show resolved Hide resolved
andy-maier
andy-maier requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@andy-maier andy-maier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@andy-maier andy-maier added this to the 1.5.0 milestone Mar 30, 2022
@tasleson
Coverity: DEADCODE correction
7f92db7 
pywbem/_recorder.py:693: dead_error_line: Execution cannot reach the expression """"
inside this statement: "ret_type = (ret ? type(ret[...".

Signed-off-by: Tony Asleson <tasleson@redhat.com>
@tasleson
coverity: FORWARD_NULL correct
fad64d3 
pywbem/cim_obj.py:1843: assign_undefined: Assigning: "kb_assigns" = "undefined".
pywbem/cim_obj.py:1957: property_access: Accessing a property of null-like value "kb_assigns".

Ensure the variable exists and is initialized as a list.

Signed-off-by: Tony Asleson <tasleson@redhat.com>
@tasleson
Copy link
Contributor Author

tasleson commented Jun 8, 2022

@andy-maier Update?

@tasleson
Copy link
Contributor Author

@andy-maier Are you waiting on something from me?

@tasleson tasleson requested a review from andy-maier July 15, 2022 13:08
@andy-maier andy-maier removed this from the 1.5.0 milestone Oct 12, 2022
@andy-maier
Copy link
Contributor

@tasleson Hi Tony. Sorry this took so long. We'll merge it into 1.7.0.

@andy-maier andy-maier added this to the 1.7.0 milestone Apr 15, 2024
@andy-maier andy-maier merged commit e389423 into pywbem:master Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-maier andy-maier andy-maier approved these changes

Assignees

@tasleson tasleson

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tasleson @coveralls @andy-maier