Code reviews?

[esev]

Just trying to gauge interest... Would anyone be interested in reviewing PRs for pyWeMo?

I see code reviews as a good software hygiene practice. They can help to catch errors before they are merged. I've been informally leaving most PRs that I create open for a week. My thought was that it'd give anyone watching the project a way to provide feedback. But I wonder if anyone would be willing to commit to reviewing my PRs? I'd be willing to review PRs for projects that others maintain in return.

[Spectre5]

It is certainly better and more fun to have a community involved and the bounce ideas back and forth. I do generally take a look at all of the pull requests you create, though admittedly have not been formally reviewing them beyond looking within the browser or phone app. I'd like to get more deeply involved, but I'm uncertain that I'll find the time too. It would be great to get another person or two actively involved with this project.

Although there are 60 forks of this project, the vast majority are very outdated. Only 5 (excluding our 2) have been updated within 2 years and only 1 other person within the last 6 months.

For anyone else reading, it is a great project to get involved with. You're likely using this through home assistant and thus it has a real effect on your day to day life. In addition, the code base is small and clean enough to wrap your head around the entire project without an excessive investment of time that is often needed for larger projects. There is more freedom than larger projects to make some real contributions too.

That said, I'm not sure the project is missing a ton of functionality either. Most of the recent work is cleaning up and improving the repository, but I'm not sure explicitly what features are still needed. Thus the code is mainly in "maintenance mode". If you disagree @esev, then definitely point it out. Perhaps adding a road map of missing features (linked to issues, I guess) would point out where contributions are particularly welcome?

[esev]

Thus the code is mainly in "maintenance mode". If you disagree @esev, then definitely point it out.

Thanks @Spectre5! I definitely agree with you here. Most of the recent work has been aimed toward automating the maintenance and deprecating parts of the code that are unused - the parts mentioned in the 0.8.0 release.

Some nice-to-haves if anyone has time:

• Implement UNSUBSCRIBE for compatibility #350
  • It'd also be interested in why the WeMo devices are unsubscribing. I suspect they should be resubscribing instead, and wonder if something in pyWeMo is broken.
• Add fader support for Dimmers #254 Home Assistant supports faders, and they're implemented for the Bridge Device, but not for the WeMo Dimmer devices.
• Modernizing the build/test setup for pyWeMo. @Spectre5 has added some thoughts in a comment on Use pre-commit for code checks in build.sh #375 (comment). I'm also working on pyWeMo release integrity #374 but have been focusing on how to implement these things with the existing build/test setup.