Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate calling get_state(True) from the Device base class constructor. #634

Open
esev opened this issue Oct 23, 2023 · 0 comments
Open

Comments

@esev
Copy link
Member

esev commented Oct 23, 2023

Possible enhancement idea: The Bridge, CoffeeMaker, CrockPot, Humidifier, Insight, and Maker devices all call the equivalent of self.get_state(force_update=False) inside __init__. If that logic was moved into the Device base class, so it'd apply to all device classes, I think that would have avoided the bug from #633.

@esev esev changed the title Investigate calling get_state(True) from the Device base class. Investigate calling get_state(True) from the Device base class constructor. Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant