chore: Support Cython 3.x #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #1102 |
|
It might also be possible to remove the Numpy API warnings, but that could be a separate PR. |
Several updates required to handle building with Cython 3.x. - Include `noexcept` for GLPK callback functions. - Handle name mangling of attributes using __. Cython 3 aligns more closely with Python 3 in this respect. There should be a review of the use of `except` given the new behaviour in Cython 3, but that is not done here.
Batch21
reviewed
Aug 23, 2023
| @@ -1,5 +1,5 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.4", "cython<3", "numpy"] | |||
There was a problem hiding this comment.
Changes to attribute names mean that Pywr can't now be built with cython<3 so this should probably be updated to "cython>=3"
Batch21
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates required to handle building with Cython 3.x.
noexceptfor GLPK callback functions.There should be a review of the use of
exceptgiven the new behaviour in Cython 3, but that is not done here.