Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate similarity between pattern in a scan and its neighbours #116

Closed
3 of 4 tasks
hakonanes opened this issue Jan 6, 2020 · 3 comments
Closed
3 of 4 tasks
Labels
enhancement New feature or request
Milestone

Comments

@hakonanes
Copy link
Member

hakonanes commented Jan 6, 2020

EBSD method to calculate similarity between each pattern in a scan (preferably with mask, most likely this feature will be implemented later) and its neighbours. Which neighbours should preferably be up to the user to decide, should start with 1st, 2nd etc. in either a cross or square. This will be similar to EMsofts average dot product (ADP) map (their implementation https://github.com/EMsoft-org/EMsoft/blob/7762e1961508fe3e71d4702620764ceb98a78b9e/Source/DictionaryIndexing/EMgetADP.f90#L360). The coefficient map can then be used e.g. to look at (how nice!), or use as input to a pattern averaging method so the similarity can be used as a weight in averaging.

Similarity metrics we should support:

This will be slow, however, let's start with the correct, naive implementation first and improve from there.

Have to wait for #15.

To do:

  • Naive implementation
  • With mask
  • Test
  • Documentation
@hakonanes hakonanes added the enhancement New feature or request label Jan 6, 2020
@hakonanes hakonanes added this to the v0.2.0 milestone Jan 6, 2020
@hakonanes hakonanes modified the milestones: v0.2.0, v0.3.0 Mar 21, 2020
@hakonanes hakonanes modified the milestones: v0.3.0, future Sep 16, 2020
@hakonanes hakonanes modified the milestones: future, v0.3.0 Oct 22, 2020
@hakonanes
Copy link
Member Author

This is implemented in #231, #232, and #233.

@hakonanes
Copy link
Member Author

Scrap the comment above, however, I think it WILL be implemented in a future PR...

@hakonanes hakonanes modified the milestones: v0.3.0, v0.4 Jan 10, 2021
@hakonanes hakonanes modified the milestones: v0.4, v0.3.0 Jan 21, 2021
@hakonanes
Copy link
Member Author

This was implemented (without a mask) by @onatlandsmyr in #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant