Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate similarity between pattern and dictionary #117

Closed
3 of 4 tasks
hakonanes opened this issue Jan 6, 2020 · 2 comments
Closed
3 of 4 tasks

Calculate similarity between pattern and dictionary #117

hakonanes opened this issue Jan 6, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@hakonanes
Copy link
Member

hakonanes commented Jan 6, 2020

EBSD method to calculate similarity between each pattern in a scan to a dictionary (preferably with a mask). Might be faster to do this as EMsoft does it, i.e. construct 2D matrices e.g. of 1024 experimental and simulated patterns, and multiplying these to collect dot products, continuously sorting them for each experimental pattern. Should perhaps start with a naive implementation an go from there.

Should be careful not to duplicate work done in pyXem: https://github.com/pyxem/pyxem/blob/master/pyxem/utils/indexation_utils.py#L44

Similarity metrics we should support:

This will be slow, however, let's start with the correct, naive implementation first and improve from there.

Have to wait for #15.

To do:

  • Naive implementation
  • With mask
  • Test
  • Documentation
@hakonanes hakonanes added the enhancement New feature or request label Jan 6, 2020
@hakonanes hakonanes added this to the v0.2.0 milestone Jan 6, 2020
@hakonanes hakonanes modified the milestones: v0.2.0, v0.3.0 Mar 21, 2020
@hakonanes hakonanes modified the milestones: v0.3.0, future Sep 16, 2020
@hakonanes hakonanes modified the milestones: future, v0.3.0 Oct 22, 2020
@hakonanes
Copy link
Member Author

This is implemented in #231, #232, and #233.

@hakonanes
Copy link
Member Author

The masking will have to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant