Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements and changes of orientation/PC refinement before v0.5 release #402

Closed
7 tasks done
hakonanes opened this issue Jul 31, 2021 · 4 comments
Closed
7 tasks done
Labels
documentation This relates to the documentation enhancement New feature or request
Milestone

Comments

@hakonanes
Copy link
Member

hakonanes commented Jul 31, 2021

We now have orientation and/or projection/pattern center (PC) refinement in from #387!

There are some things we must improve and some things we can improve before a v0.5 release, which this issue keeps track of:

The PR number behind each task is the relevant PR where this is done or planned to be done.

@hakonanes hakonanes added enhancement New feature or request documentation This relates to the documentation labels Jul 31, 2021
@hakonanes hakonanes added this to the v0.5.0 milestone Jul 31, 2021
@hakonanes
Copy link
Member Author

I've started this work in my fork https://github.com/hakonanes/kikuchipy/tree/internal-improvements-refinement. I hope to keep it to one PR, we'll see if that is doable.

@friedkitteh
Copy link
Collaborator

Great! Let me know if I can be of assistance.

@hakonanes
Copy link
Member Author

Will do, thanks @friedkitteh!

@hakonanes
Copy link
Member Author

All except the last point about allowing to refine one phase from a multiphase crystal map (converted into its own issue) has now been implemented. RTD cannot build the latest documentation yet (a fix is on the way in #410), but the refinement examples in the pattern matching notebook can be viewed here: https://kikuchipy--410.org.readthedocs.build/en/410/user_guide/pattern_matching.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This relates to the documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants