Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print indexing speed after completed indexing #452

Closed
hakonanes opened this issue Oct 11, 2021 · 1 comment · Fixed by #461
Closed

Print indexing speed after completed indexing #452

hakonanes opened this issue Oct 11, 2021 · 1 comment · Fixed by #461
Labels
enhancement New feature or request
Milestone
v0.5.3

Comments

@hakonanes
Copy link
Member

We could print e.g. patterns per second (PPS, # patterns / indexing time), after indexing is completed (relevant user guide part).

Actually, we could tell tqdm to print PPS alongside the iterations per second (it/s), so that the user sees this number during indexing. I don't know if the final number shown after completed indexing is an average or the iteration speed for the last iteration. Should check this.

It might be OK to release such a small feature in v0.5.3 whenever we release that.
@hakonanes hakonanes added the enhancement New feature or request label Oct 11, 2021
@hakonanes hakonanes added this to the v0.5.3 milestone Oct 11, 2021
@hakonanes hakonanes mentioned this issue Nov 2, 2021
Merged
7 tasks
@hakonanes hakonanes linked a pull request Nov 2, 2021 that will close this issue
Print indexing and refinement speed #461
Merged
7 tasks
@hakonanes
Copy link
Member Author

Added in #461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.3
Development

Successfully merging a pull request may close this issue.

Print indexing and refinement speed hakonanes/kikuchipy
1 participant
@hakonanes