Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsidering the overwritten operators #139

Open
pc494 opened this issue Nov 15, 2020 · 0 comments
Open

Reconsidering the overwritten operators #139

pc494 opened this issue Nov 15, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@pc494
Copy link
Member

pc494 commented Nov 15, 2020

Currently, almost everything that inherits from Object3d has overwritten +,-,* and / but the discussion #138 has suggested that we might want to have a careful think about how these should work.

If we are tabulating, we would expect to do int, float, tuple, list, array and other relevant orix objects, from both left and right.

I think there can't be much debate about that int and float should do the same thing, and tuple and list should be turned into numpy arrays. The main questions seem to come up about how to combine things of different dimensions. If anyone has strong generic preference we can start there, and then in a couple of days I'll see if I can write a summary of what I think would work best.

@pc494 pc494 added the enhancement New feature or request label Nov 15, 2020
@pc494 pc494 mentioned this issue Dec 8, 2020
9 tasks
@pc494 pc494 added this to the v0.6.0 milestone May 8, 2021
@pc494 pc494 removed this from the v0.6.0 milestone May 23, 2021
@hakonanes hakonanes added this to the v1.0.0 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants