Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that some installers don't install pyxl.pth #24

Open
bdarnell opened this issue Nov 30, 2020 · 0 comments
Open

Document that some installers don't install pyxl.pth #24

bdarnell opened this issue Nov 30, 2020 · 0 comments

Comments

@bdarnell
Copy link

This commit doesn't work in all cases. Specifically, when installing with poetry, the destination path for all data_files is prepended with the site-packages directory, so everything gets doubled: /opt/virtualenvs/python3/lib/python3.8/site-packages/opt/virtualenvs/python3/lib/python3.8/site-packages/pyxl.pth.

There might be some way to fix this (either by detecting poetry and specifying an alternate path, or lobbying for changes to poetry to improve compatibility), but setuptools' docs say data_files is deprecated and not supported when using wheels, so unless there's another clever solution I'm not seeing it might be better to just document the issues, and the fact that you may need to import pyxl.codec.register manually (before importing any file with # coding: pyxl)

P.S. I'm the one who originally introduced the pyxl.pth trick here back when I worked at dropbox. 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant