Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gte, lte used on optional package #54

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Conversation

igorT
Copy link
Contributor

@igorT igorT commented Aug 6, 2021

Previously this was always throwing an error when trying to compare a
missing dependency at build time. There is no error handling provided
anyway provided by this project, and detecting a missing dependency is
better done at addon's build entry.

Previously this was always throwing an error when trying to compare a
missing dependency at build time. There is no error handling provided
anyway provided by this project, and detecting a missing dependency is
better done at addon's build entry.
@pzuraq pzuraq merged commit 34f0eb8 into ember-cli:master Aug 6, 2021
@igorT igorT deleted the optional branch August 6, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants