[Bug]: resolve error in build without browsers in targets.js file #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋🏼 I'm helping out with maintenance here now (@pzuraq is kind of slammed)! Mind rebasing so this'll run through CI? It looks perfectly safe and reasonable to me, but… 😬 I have been bitten enough times by perfectly safe and reasonable to not want it to go through CI! |
snewcomer
force-pushed
the
sn/no-browsers
branch
from
2a74908
to
1be48f6
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our build scenarios, we export
esmodules: true,instead of a list of browsers.