Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

still necessary? #17

Closed
konne opened this issue Jul 29, 2017 · 2 comments · Fixed by #27
Closed

still necessary? #17

konne opened this issue Jul 29, 2017 · 2 comments · Fixed by #27
Assignees
@thomashaenig

Comments

@konne
Copy link
Contributor

konne commented Jul 29, 2017

see code line:

q2g-ext-selector/src/q2g-ext-selectorDirective.html

Line 4 in 0382c67

q2g-shortcut-scope="'rootelement'">

@thomashaenig
Copy link
Contributor

Hi,
i checked the code and did some small code quality fixes.
The property “q2g-shortcut-scope” on a html element to specify the element as a root element for a local shortcut (the element in which subelements the focus should be) is still required. But this should not have to be an own directive, or even need a value, it just needs to be set as a property on a html element.

@konne
Copy link
Contributor Author

konne commented Sep 26, 2017

  1. please remove the directive and just use this as a html attribute
  2. q2g-shortcut-scope as stopper is great
  3. q2g-shortcut-scope="NAME" as NAMED stopper is also great

@thomashaenig thomashaenig mentioned this issue Sep 26, 2017
Merged
@konne konne closed this as completed in #27 Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomashaenig thomashaenig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix and issue close thomashaenig/q2g-ext-selector
2 participants
@konne @thomashaenig