-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytket coverage, tests, and passable through run/exec methods #162
Comments
yah, you are right, so pytket qasm doesn't support some gates like iswap, that's why I purposely commented todo, those tests will be added like qiskit after doing a transpiler like braket_cirq, that will take some time, as there is some special gate are not able to direct add_gate from cirq to pytket, so require extra if else statement. |
@junliangtan1 Gotcha. Yeah we probably want to stay away from implementing anymore custom cirq gates, since that approach isn't very scalable. Instead, if it's the qasm to pytket methods that are breaking for specific gates, we could implement some pre-processing of the qasm string to replace the iswap and other unsupported gates with an equivalent gate decomposition that will be compatible with pytket. I faced a similar problem with qasm to cirq conversions earlier. Certain qasm strings (mainly ones generated from qiskit circuits) were not compatible with the cirq's default Taking this approach for iswap and other gates for pytket shouldn't be too difficult. Just follow the logic used in
|
The text was updated successfully, but these errors were encountered: