Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Viewport: OuterWidth issue with jQuery 1.8+ #497

Closed
rpotsakis opened this issue Apr 3, 2013 · 1 comment
Closed

Viewport: OuterWidth issue with jQuery 1.8+ #497

rpotsakis opened this issue Apr 3, 2013 · 1 comment

Comments

@rpotsakis
Copy link

I found an issue when using a jQuery object as the viewport. Lines 3062-3063 have the following (in the unminified js)

height: viewport[ (viewport[0] === window ? 'h' : 'outerH') + 'eight' ](),
width: viewport[ (viewport[0] === window ? 'w' : 'outerW') + 'idth' ](),

When viewport is true there needs to be a parameter passed to outerWidth/Height. I believe you fixed this in other places but probably missed this one based on the way it is called here.

Thanks!

@Craga89 Craga89 closed this as completed in 8ccba50 Apr 3, 2013
@rpotsakis
Copy link
Author

Awesome, that resolved the issue I had. Thanks for the super quick response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant