Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support path names with spaces #7

Closed
thirteen37 opened this issue Oct 16, 2013 · 4 comments
Closed

Does not support path names with spaces #7

thirteen37 opened this issue Oct 16, 2013 · 4 comments

Comments

@thirteen37
Copy link

FileUtils::setExecutable does not work properly with a path name that has spaces since the path is not quoted in the exec command.

An alternative cross-platform fix, given that the File object is already available, would be to call File.setExecutable(true)

@lfryc
Copy link

lfryc commented Oct 22, 2013

Hey @thirteen37 , could you please note a platform you use and its version
so we could reproduce the issue?

Would you mind to conceive this patch as a pull request?

@thirteen37
Copy link
Author

OSX 10.8, but it should reproduce on any "Unix" platform with a filesystem that supports spaces in the path, e.g., "/Users/thirteen37/Documents/My Project/". FileUtils::setExecutable will exec chmod +x /Users/thirteen37/Documents/My Project/target/phantomjs (or some similar path, I can't remember the exact phantomjs binary path) which is interpreted as chmod on two files: "/Users/thirteen37/Documents/My" and "Project/target/phantomjs"

I'll see if I can submit a pull request soon.

@lfryc
Copy link

lfryc commented Jan 24, 2014

Hey @thirteen37 any chance to get pull request for the suggested fix?

@michbeck100
Copy link
Contributor

When will the pull request be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants