Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot symlink or hardlink: can only delete dupes #373

Closed
Rings4 opened this issue Jun 4, 2021 · 14 comments · Fixed by #410 or #668
Closed

Cannot symlink or hardlink: can only delete dupes #373

Rings4 opened this issue Jun 4, 2021 · 14 comments · Fixed by #410 or #668

Comments

@Rings4
Copy link

Rings4 commented Jun 4, 2021

Scanned 2 directories, clicked "select all except oldest", then clicked hardlink: nothing happened. Symlink didn't do anything either. Delete works, but I don't want to delete.

@NAHNAH55
Copy link

Same issue. Symlink function does nothing. I wish I knew this before spending all day scanning my files.

@qarmin
Copy link
Owner

qarmin commented Jul 27, 2021

What OS?
If windows, then for now only simlinks are implemented.
For unix like os(which use inode like Linux or macOS) it should work both symlink and hardlink

@NAHNAH55
Copy link

NAHNAH55 commented Jul 27, 2021

Win 10. I haven't tried hard links, but symlinks don't work. I've tried both elevated and not elevated access. I select a file, press the symlink button and the file(s) are deselected. No change takes place, neither file has been replaced with a link.

@Rings4
Copy link
Author

Rings4 commented Jul 27, 2021

dupeGuru works with symlinks and hardlinks just fine. Perhaps you can look at what they're doing to implement into your own software? https://dupeguru.voltaicideas.net/

@qarmin
Copy link
Owner

qarmin commented Aug 7, 2021

The problem is mostly with functions which Rust standard library provide(Rust and Python differs a lot)
Symlink on Windows problem should be fixed by #409

@qarmin
Copy link
Owner

qarmin commented Aug 7, 2021

Hard-links should probably works with the latest version(future 3.2 version)

@mascherone108
Copy link

I'm using Kubuntu 21.04 and it still doesn't work for me just as OP described.

@qarmin
Copy link
Owner

qarmin commented Aug 22, 2021

Oh, now I understand what is happening(I think that this behavior is somewhere documented).

Symlinks and Hardlinks can be generated only if in group is at least 2 selected results.
1 result is always unchanged and second and furthers are hardlinked to first.

I reopened issue because in future I probably can implement this(this require to do some deep changes in method how hardlinks or symlinks are handled)

@qarmin qarmin reopened this Aug 22, 2021
@TiagoTiago
Copy link

How do I select which one of the files will be the target of the symlink?

@Bartek200219
Copy link

When I try to create hard link program crashes.
(Czkawka 3.2.0
Windows 10 2004)

@qarmin
Copy link
Owner

qarmin commented Dec 5, 2021

Crash when hardlinking is fixed in master branch, but still happens with 3.3.1 version and it show when clicking at hardlink/symlink button without any record selected.

Warning message about it is added in this PR - #489

For now I don't see simple and clear for user method to set target of file used in hardlinking

@z0diaq
Copy link

z0diaq commented Dec 16, 2021

What about drag and drop within groups to change ordering ?
So old behavior of first file is kept unchanged and other pointing to would remain and users still could choose what should stay.
This is quite important feature missing since there are many times 'source locations' and 'copies' and most of the time (if not like always?) I want to change 'copies' to point to source locations not other way around so after copy is deleted other links will stay valid (talking about symlinks)

@z0diaq
Copy link

z0diaq commented Dec 16, 2021

Also current behavior is very non intuitive (3.3.1) - I've also spent some time trying to figure out how to use symlink \ hardlink... Same as author of topic I've thought I should choose single file and other files from group will point to it... was quite lost after clicking hardlink \ softlink and nothing happened - 'these buttons work at all?' and started to search on web for and found this thread...

Would be great if You could spend some time on improving current behavior, what I could suggest these approaches to consider:

  • r-click and select 'make primary' to select which stays and which will be changed to link
  • allow to drag and drop within group to change ordering
  • also disable or at least show error message when user selects single item and clicks any of link buttons
  • please don't remove items from list if operation fails - for example hardlink may fail but softlink may pass - had exactly this issue today, had to scan again to restore found dups

@login404
Copy link

login404 commented Jan 21, 2022

Creating hard links can not work, showing refusal access
But the symbolic link can work properly
dupeGuru hard links and symbolic links can work properly
The test results on Windows 7 and Windows 10 21H2 (19044.1415) are the same

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants