Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$(MODIF) tag in custom rules does not fully work (Windows version) #17

Closed
biru-cs opened this issue May 14, 2021 · 1 comment
Closed

Comments

@biru-cs
Copy link

biru-cs commented May 14, 2021

I may be your first Windows tester. If that is truly the case, I'm really glad because Rust has recently drawn a lot more attention and this project looks promising. It's nice to see an open source app being also built for Windows :)

Onto the bug I've noticed in the Windows build:
The $(MODIF) tag in the custom rules does not work properly: it is shown in the status view (image 1, below), it tries to rename the file(s) accordingly when I click on the "Start Renaming" button and confirm, but fails, saying "Ignored 1 file(s), because there" (size issues with the results dialog box?) (image 2, below). After this, the same file(s) cannot be added anymore, even after reopening the executable. If the rule is anything other than a custom rule (I've not tested any other tags yet), the batch renaming works perfectly fine and the same file(s) can be re-added without any issues.

image

image

Improvements (in my opinion, at least):

  1. In the Windows build, a command prompt window opens. Perhaps you could hide it from the end user. If not, I personally don't mind.
  2. Bigger text for some elements (e.g. "Status" in the status pane in the lower area)

Other than that, the app is great! Keep on!

@qarmin
Copy link
Owner

qarmin commented May 21, 2021

Fixed by #27
Custom rules also on Linux not always work properly, but this should be mostly fixed.
Console shouldn't be visible on Windows
Also information about ignored files is now proper

@qarmin qarmin closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants