Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is module path changing? #1079

Closed
dolmen opened this issue Dec 2, 2021 · 4 comments
Closed

Is module path changing? #1079

dolmen opened this issue Dec 2, 2021 · 4 comments

Comments

@dolmen
Copy link
Contributor

dolmen commented Dec 2, 2021

Description

The repository is now at https://github.com/qax-os/excelize/
But go.mod still says: github.com/xuri/excelize/v2

What is happening?

@xuri
Copy link
Member

xuri commented Dec 2, 2021

I'm sorry for bringing you confusion, this issue is similar with #973 and #1020. For some reasons, I must accept the organization name change, so I decided to use the original module name: github.com/xuri/excelize, and that path won't be change in the future

@dolmen
Copy link
Contributor Author

dolmen commented Dec 2, 2021

The import/module path not matching the repository URL is still confusing.

And we have to change all code references (imports and go.mod).

sed -i '' -e 's!"github.com/360EntSecGroup-Skylar/excelize/v2"!"github.com/xuri/excelize/v2"!' go.mod
sed -i '' -e 's!"github.com/360EntSecGroup-Skylar/excelize/v2"!"github.com/xuri/excelize/v2"!' $(go list -f '{{$Dir := .Dir}}{{range .GoFiles}}{{$Dir}}/{{.}} {{end}}{{range .TestGoFiles}}{{$Dir}}/{{.}} {{end}}{{range .XTestGoFiles}}{{$Dir}}/{{.}} {{end}}' ./...)
go mod tidy

@dolmen
Copy link
Contributor Author

dolmen commented Dec 7, 2021

@xuri You should have switched to v3 because in practice a module path change is like a change of major version for end users. Now everybody has to change go.mod/go.sum and all imports in Go files like if it was a new major version.
https://research.swtch.com/vgo-principles

@xuri
Copy link
Member

xuri commented Dec 16, 2021

Thanks for your advice, but this module path change has been take effect since already released verion 2.4.1, so I hope to using the 2.5.0 for next version, and I'd like to follwing the semantic version practice in the future versions release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants