Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are state-full and chaotic #322

Closed
albenik opened this issue Dec 27, 2018 · 1 comment
Closed

Tests are state-full and chaotic #322

albenik opened this issue Dec 27, 2018 · 1 comment

Comments

@albenik
Copy link
Contributor

albenik commented Dec 27, 2018

Description

  • Multiple tests reads and overwrites single file without
  • Multiple tests reads and overwrites file Book1.xlsx under version control:
    • It makes VCS tree dirty after test.
    • Every second run operates test data not equals to first run (on clean VCS tree state).
    • File with test data can be occasionally commited and possible break future tests.
  • Multiple unrelated check placed in single unit test run without any isolation.

Steps to reproduce the issue:

  1. Checkout master
  2. Rut tests go test ./...
  3. Check file tree state git state

Describe the results you received:

Same VCS file tree state after every test run.

Describe the results you expected:

Dirty VCS file tree state after test run.

Output of go version:

go version go1.11.4 darwin/amd64

Excelize version or commit ID:

9a6f66a996eb83f16da13416c5fca361afe575b0

Environment details (OS, Microsoft Excel™ version, physical, etc.):

MacOS Mojave

@albenik albenik mentioned this issue Dec 27, 2018
10 tasks
@albenik
Copy link
Contributor Author

albenik commented Dec 27, 2018

It will be better to discuss relative to real code, so I made PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants