Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't exclude linters/spellcheck and vendor #19

Closed
derekstavis opened this issue Jun 12, 2017 · 4 comments
Closed

Can't exclude linters/spellcheck and vendor #19

derekstavis opened this issue Jun 12, 2017 · 4 comments
Labels

Comments

@derekstavis
Copy link

Looks like -e flag isn't working with linters/spellcheck.

When running goreporter on our project the following way:

$ goreporter -e vendor,linters/spellcheck -f json -p ../thunderbolt 

SpellCheck isn't being ignored. When running ignoring only vendor:

$ goreporter -e vendor -f json -p ../thunderbolt 

It looks like every linter is ignoring vendor, but SpellCheck isn't.

Evidences:

...
        "compress": {
          "name": "github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress",
          "description": "",
          "errors": [
            {
              "line_number": 23,
              "error_string": "/home/derek/go/src/github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress/README.md:23:141: \"progresssion\" is a misspelling of \"progressions\""
            },
            {
              "line_number": 200,
              "error_string": "/home/derek/go/src/github.com/pagarme/thunderbolt/vendor/github.com/klauspost/compress/README.md:200:121: \"descibed\" is a misspelling of \"described\""
            }
          ]
        },
...

@derekstavis derekstavis changed the title Can't ignore linters/spellcheck + spellcheck doesn't ignore vendor Can't exclude linters/spellcheck and vendor Jun 12, 2017
@wgliang
Copy link
Collaborator

wgliang commented Jun 13, 2017

Yes, I understand your issue. SpellCheck is about to join linters, but I have not figured out how the page is displayed. This problem I will try to fix it as soon as possible. Thx!

@wgliang
Copy link
Collaborator

wgliang commented Jun 13, 2017

Now,you can pull last update and run goreporter on your project.Any questions can contact me. Thank you for issue.

@wgliang
Copy link
Collaborator

wgliang commented Jun 16, 2017

Did I solve your problem? I want to close the issue if you are ok.
@derekstavis

@derekstavis
Copy link
Author

Hey @wgliang, it solved my issue!! Thanks a lot for your time!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants