Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust or redesign genre navigation bar #12

Closed
QAZIMAAZARSHAD opened this issue Jun 1, 2021 · 30 comments
Closed

Adjust or redesign genre navigation bar #12

QAZIMAAZARSHAD opened this issue Jun 1, 2021 · 30 comments
Assignees
@Sourav61
Labels
enhancement New feature or request good first issue This issue is good for first timers 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 5 LGMSOC21 This issue will be considered for LGM-SOC 21

Comments

@QAZIMAAZARSHAD
Copy link
Owner

WhatsApp Image 2021-06-01 at 7 19 41 PM

Make sure all genre names are in one single line side by side.
@QAZIMAAZARSHAD QAZIMAAZARSHAD added enhancement New feature or request Easy lgm-soc labels Jun 1, 2021
@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

@QAZIMAAZARSHAD i'll would like to work on this issue

@QAZIMAAZARSHAD
Copy link
Owner Author

I will assign you this issue when the contribution period starts then you can start working on this issue.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

Capture

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021 •
edited

Is this alright @QAZIMAAZARSHAD sir or You want some other changes?

@QAZIMAAZARSHAD
Copy link
Owner Author

This is almost similar, I don't see any change.

I want all genre names in one single line, so it looks nice.
Like Home, Movies, Web Series, Kids, navigation bar. See these in one line.

image

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

But comedy is now in one line along with others @QAZIMAAZARSHAD

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

I'll try to make Suspense & Thriller and SciFy & Fantasy in one line as well

@QAZIMAAZARSHAD
Copy link
Owner Author

yes

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

Capture1

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

Is this fine now @QAZIMAAZARSHAD ?

@QAZIMAAZARSHAD
Copy link
Owner Author

Yes, nice

But do not make any pull requests now because points will be awarded only for pull requests merged during the contribution period which is starting from 10th June.
Also while making the pull requests don't forget to mention the issue number.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

Screenshot 2021-06-02 112325

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

But when we are hovering over it ,then it appears like this. Is it okay?

@QAZIMAAZARSHAD
Copy link
Owner Author

You can improve this issue, there is plenty of time.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

Should i create a new issue for that?

@QAZIMAAZARSHAD
Copy link
Owner Author

No, since your improvement has not been accepted yet

You can improve your design.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 2, 2021

okk thanks @QAZIMAAZARSHAD sir

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021

Capture4 JPG

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021

Now hovering problem is solved as well @QAZIMAAZARSHAD

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021 •
edited

But I have changed the Font size of text. Is it a right thing to do sir?

@QAZIMAAZARSHAD
Copy link
Owner Author

It's better than before. Nice!

You can always try to improve.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021 •
edited

Thanks alot @QAZIMAAZARSHAD sir

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021 •
edited

Should i create a PR now @QAZIMAAZARSHAD sir?

@QAZIMAAZARSHAD
Copy link
Owner Author

No,
After 10th June when I will assign you this issue.

In any open-source event don't make PR's directly if you are not assigned. You might not gain points for your work.

@Sourav61
Copy link
Contributor

Sourav61 commented Jun 3, 2021

Okk thanks a lot @QAZIMAAZARSHAD sir

@rucha0702
Copy link

Can I also work upon this issue?

@QAZIMAAZARSHAD
Copy link
Owner Author

@rucha0702 I think @Sourav61 has already resolved this issue.

When I will merge @Sourav61's PR and if any error or scope of improvement will be there I will assign you this issue.

@rucha0702
Copy link

okay

@QAZIMAAZARSHAD QAZIMAAZARSHAD added good first issue This issue is good for first timers and removed Easy labels Jun 10, 2021
@QAZIMAAZARSHAD QAZIMAAZARSHAD mentioned this issue Jun 10, 2021
Closed
@QAZIMAAZARSHAD QAZIMAAZARSHAD added LGMSOC21 This issue will be considered for LGM-SOC 21 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 5 and removed lgm-soc labels Jun 10, 2021
@Sourav61 Sourav61 mentioned this issue Jun 11, 2021
Merged
@ghost
Copy link

ghost commented Jun 11, 2021

I would like to work on this issue

@QAZIMAAZARSHAD
Copy link
Owner Author

I would like to work on this issue

Already solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sourav61 Sourav61

Labels
enhancement New feature or request good first issue This issue is good for first timers 🟩 Level1 This issue will be considered as level 1 issue for LGM-SOC 21.Points will be 5 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@QAZIMAAZARSHAD @Sourav61 @rucha0702