Performance Issue inside of Loop

[AvarianKnight]

Some users inside of the txAdmin discord recently reported performance issues related to qb-adminmenu which was from this loop.

qb-adminmenu/server/server.lua

Lines 524 to 548 in 42f4f89

	CreateThread(function()
	while true do
	local tempPlayers = {}
	for _, v in pairs(QBCore.Functions.GetPlayers()) do
	local targetped = GetPlayerPed(v)
	local ped = QBCore.Functions.GetPlayer(v)
	tempPlayers[#tempPlayers + 1] = {
	name = (ped.PlayerData.charinfo.firstname or '') .. ' ' .. (ped.PlayerData.charinfo.lastname or '') .. ' | (' .. (GetPlayerName(v) or '') .. ')',
	id = v,
	coords = GetEntityCoords(targetped),
	cid = ped.PlayerData.charinfo.firstname .. ' ' .. ped.PlayerData.charinfo.lastname,
	citizenid = ped.PlayerData.citizenid,
	sources = GetPlayerPed(ped.PlayerData.source),
	sourceplayer = ped.PlayerData.source
	}
	end
	-- Sort players list by source ID (1,2,3,4,5, etc) --
	table.sort(tempPlayers, function(a, b)
	return a.id < b.id
	end)
	players = tempPlayers
	Wait(1500)
	end
	end)

There are functions that QB already has to deal with this (GetQBPlayers) to prevent constant serialization.

It might also be worth thinking about the data structure used to store player info and offer a "minimal qb player" that only has the users player data